fix(filterable-select): ensure list does not reopen when user clicks option and openOnFocus prop set #6476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd9e29e:
|
robinzigmond
previously approved these changes
Dec 8, 2023
DipperTheDan
previously approved these changes
Dec 8, 2023
edleeks87
dismissed stale reviews from DipperTheDan and robinzigmond
via
5f9c263
…option and openOnFocus prop set Ensures that the `SelectList` does not reopen when a user selects and `Option` via clicking and the `openOnFocus` prop is set. fix #6462
edleeks87
force-pushed
the
FE-6292-fs
branch
from
5f9c263
to
e143aaa
Compare
robinzigmond
approved these changes
Dec 11, 2023
DipperTheDan
approved these changes
Dec 11, 2023
stephenogorman
approved these changes
Dec 11, 2023
|
🎉 This PR is included in version 124.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6462
Proposed behaviour
Ensures that the
SelectListdoes not reopen when a user selects andOptionvia clicking and theopenOnFocusprop is set.Current behaviour
The
SelectListreopens when a user selects andOptionvia clicking and theopenOnFocusprop is set.Checklist
QA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].